Skip to content

Allow to opt out from special naming when fieldname ends with _id #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 8, 2025
Merged

Allow to opt out from special naming when fieldname ends with _id #356

merged 5 commits into from
Nov 8, 2025

Conversation

@Henkhogan
Copy link
Contributor

@Henkhogan Henkhogan commented Jan 4, 2025 •
edited by sheinbergon
Loading

Fixes #355

@Henkhogan Henkhogan changed the title Allow to opt out from special naming when fieldname ends with _id #355 Allow to opt out from special naming when fieldname ends with _id Jan 4, 2025
@coveralls
Copy link

coveralls commented Jan 23, 2025 •
edited
Loading

Coverage Status

coverage: 97.64% (+0.008%) from 97.632%
when pulling 51f0019 on Henkhogan:master
into cf87688 on agronholm:master.

@Henkhogan Henkhogan mentioned this pull request Mar 4, 2025
Closed
1 task
@sheinbergon
Copy link
Collaborator

sheinbergon commented Oct 18, 2025

@agronholm Given the tests are fixed. How do you feel about merging this PR?

@sheinbergon sheinbergon added this to the 3.1.x milestone Oct 18, 2025
@sheinbergon sheinbergon self-assigned this Oct 18, 2025
@sheinbergon
Copy link
Collaborator

sheinbergon commented Oct 22, 2025

@agronholm Given the tests are fixed. How do you feel about merging this PR?

@agronholm would love to hear your opinion

@agronholm
Copy link
Owner

agronholm commented Oct 23, 2025

I guess I'm okay with it.

@agronholm
Copy link
Owner

agronholm commented Oct 23, 2025

Needs a changelog entry too.

@sheinbergon
Copy link
Collaborator

sheinbergon commented Oct 23, 2025

@Henkhogan would you mind remdying your PR? Fix the tests to meet latest version changes + add change log entry?

@sheinbergon sheinbergon requested a review from agronholm November 6, 2025 21:31
@sheinbergon
Copy link
Collaborator

sheinbergon commented Nov 6, 2025

@agronholm I fixed the bad tests and added a changelog entry. Please review

agronholm
agronholm approved these changes Nov 6, 2025
View reviewed changes
Copy link
Owner

@agronholm agronholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@agronholm
Copy link
Owner

agronholm commented Nov 7, 2025

On another note, I noticed that the CI currently doesn't test against Python 3.14. And now with 3.9 past its EOL, maybe it's time to drop that?

@sheinbergon
Copy link
Collaborator

sheinbergon commented Nov 7, 2025

On another note, I noticed that the CI currently doesn't test against Python 3.14. And now with 3.9 past its EOL, maybe it's time to drop that?

Look like you've already taken care of that. Great!

@sheinbergon sheinbergon merged commit d7a6024 into agronholm:master Nov 8, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agronholm agronholm agronholm approved these changes

Assignees

@sheinbergon sheinbergon

Labels

None yet

Projects

None yet

Milestone

3.1.x

Development

Successfully merging this pull request may close these issues.

Allow to opt out from special naming when fieldname ends with _id

4 participants

@Henkhogan @coveralls @sheinbergon @agronholm